Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Disable "Show Counter" test (temporarily) for Chrome - #17274

Merged
zoracon merged 2 commits into
EFForg:masterfrom
zoracon:fix-show-counter
Jan 31, 2019
Merged

zoracon merged 2 commits into
EFForg:masterfrom
zoracon:fix-show-counter

Conversation

@zoracon

@zoracon zoracon commented Jan 25, 2019 •

Copy link
Copy Markdown
Contributor
  • Show counter has been failing lately for many PRs
  • Suspected cause: deprecation warning
  • Pushing fix for deprecation
    Message
    (Warnings.warn('use options instead of chrome_options', DeprecationWarning))

Edit: Checks out to not be the issue, will investigate further for a solution

Going to skip the test for now in Chrome. If not hashed out by Release time I will merge for the sake of people's PRs

- Show counter has been failing lately for many PRs
- Suspected cause: deprecation warning
- Pushing fix for deprecation
@zoracon
zoracon requested a review from Hainish January 25, 2019 01:48
@zoracon
zoracon removed the request for review from Hainish January 25, 2019 01:55
@zoracon zoracon self-assigned this Jan 25, 2019
@zoracon

zoracon commented Jan 31, 2019

Copy link
Copy Markdown
Contributor Author

Pulling an Apple and skipping test for now with Chrome, while working on a solution for fixing this.

@zoracon zoracon changed the title Potential patch for flaky "Show Counter" test Disable "Show Counter" test (temporarily) for Chrome Jan 31, 2019
@zoracon
zoracon merged commit 41501f0 into EFForg:master Jan 31, 2019
zoracon added a commit that referenced this pull request Jan 31, 2019
@zoracon
zoracon deleted the fix-show-counter branch May 15, 2020 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant